added driver for MLX90614 Temperature sensor #26886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulOCR
changed the title
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
b4d6ee0
to
0bed8bb
Compare
peterbarker
requested changes
Apr 26, 2024
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
47e0fd0
to
b489499
Compare
peterbarker
requested changes
Apr 26, 2024
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
IamPete1
reviewed
Apr 26, 2024
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
peterbarker
requested changes
Aug 13, 2024
There was a problem hiding this comment.
@rahulOCR still working on this one? There's a couple of reviews outstanding
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
|
hey @peterbarker I am waiting for some dev call or similar to review and should I squash all commits into one single commit ? |
peterbarker
requested changes
Aug 13, 2024
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
libraries/AP_TemperatureSensor/AP_TemperatureSensor_MLX90614.cpp
Outdated
Show resolved
Hide resolved
Hwurzburg
reviewed
Aug 14, 2024
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
c8fc525
to
486c178
Compare
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
c710211
to
693258b
Compare
peterbarker
requested changes
Aug 19, 2024
|
@peterbarker I think this NEW_NOTHROW was recently added. will do that |
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
693258b
to
e2d8940
Compare
Hwurzburg
requested changes
Aug 20, 2024
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
e2d8940
to
66c51e3
Compare
|
Hey @Hwurzburg can you help me out what needs to be changed in extract_featues.py |
|
@peterbarker would be better at that |
rahulOCR
force-pushed
the
pr-mlx90-sensor
branch
from
c51d3f8
to
d96bf3e
Compare
peterbarker
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
I've tested this rebased against master (#28143) and it seems to work as expected.
Maybe reading a bit low?
Very long time constants?
Merging, thanks!
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone,
I am resubmitting this PR as per code of conduct of Ardupilot after closing #26644
I am submitting this PR to merge into master. I have added MLX90614 temperature sensor into AP_TemperatureSensor library.
Using data-sheet provided [Link of data-sheet]](https://www.melexis.com/en/documents/documentation/datasheets/datasheet-mlx90614). I have used this to get ambient temperature of cabin of battery.
WIKI:
Hi I am attaching datasheet, wiki and photos for interfacing. MLX90614 sensor is an infrared thermometer for non-contact temperature measurements. Both the IR sensitive thermopile detector chip and the signal conditioning ASIC are integrated in the same TO-39 can. Integrated into the MLX90614 are a low noise amplifier, 17-bit ADC and powerful DSP unit thus achieving high accuracy and resolution of the thermometer.
set (examples shown for first sensor):
TEMP1_TYPE = 0:Disabled, 1:TSYS01, 2:MCP9600, 3:MAX31865, 4:TSYS03, 5:Analog, 6:DroneCAN, 7:MLX90614 Sensor type
TEMP1_BUS = 0-3 Board’s I2C port on which the sensor is attached
TEMP1_ADDR = the sensor’s I2C address (0-127). For this sensor, 90
TEMP1_SRC = which other temperature reporting device type should have its temperature report replaced with this sensor’s.
TEMP1_SRC_ID = this identifies which individual device, of the above type, should have its report replaced.
MLX90614-Datasheet-Melexis.pdf